Fix courses sorting#2
Open
tonicgi wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original problem: Courses were sorted incorrectly on different browsers. They might have been under incorrect modules or even outside of their module. This was especially apparent on Firefox.
Fix: Change the way courses are sorted. Previously they were sorted using calculated weight value but now for the most part they use the "hasPart" value that contains all the related courses. For example a module's hasPart contains courses that are linked with it. These are pushed into an array which should be the correct order.
We also handle modules and courses that are possibly not linked to anything. The process also contains alphabetic sorting.