Conversation
NateMeyer
reviewed
Jul 26, 2024
Comment on lines
+32
to
+33
| | `<ChannelIndex>:OFFS` | | | | | | ||
| | `<ChannelIndex>:RANGE` | | | | | No newline at end of file |
Contributor
There was a problem hiding this comment.
Do we need a query version of the OFFS and RANGE commands to get the actual offset and range applied to a channel?
Collaborator
Author
There was a problem hiding this comment.
Sounds reasonable to me, we probably want to have OFFS? and OFFS:ACTual? to allow for the reading of both requested offset (e.g. freshly loaded UI getting current state of scope) and actual offset.
macaba
force-pushed
the
main
branch
2 times, most recently
from
773e8b9 to
3843e5b
Compare
macaba
force-pushed
the
main
branch
3 times, most recently
from
eefeabf to
2c9a1a7
Compare
macaba
force-pushed
the
main
branch
2 times, most recently
from
5bdc6e1 to
c8ae395
Compare
macaba
force-pushed
the
main
branch
4 times, most recently
from
2313e9c to
db42a1b
Compare
macaba
force-pushed
the
main
branch
5 times, most recently
from
98483f0 to
af70d79
Compare
macaba
force-pushed
the
main
branch
2 times, most recently
from
71e144a to
a50438c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.