improve usability: e.g. remove set -e to have shell survive typo#24
Open
hugomeiland wants to merge 3 commits into
Open
improve usability: e.g. remove set -e to have shell survive typo#24hugomeiland wants to merge 3 commits into
hugomeiland wants to merge 3 commits into
Conversation
hugomeiland
changed the title
boegel
requested changes
Apr 25, 2026
Comment on lines
+39
to
+40
| "-v", | ||
| "--eessi_version", |
Contributor
There was a problem hiding this comment.
I would be surprised if eessi shell -v doesn't just print the version of the EESSI CLI tool, so perhaps we can use -e here?
Also, I much prefer --eessi-version over --eessi_version, underscores in CLI options are weird imho...
Author
There was a problem hiding this comment.
actually the -v was working fine ;)
but updated these...
would it make sense to set the latest version as the default? (even though the lastest symlink was removed?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #8