Fix "NULL pointer to instance" error#7
Open
tjensen wants to merge 1 commit into
Open
Conversation
The modded `UnlockServer` method override casts the parent (door) entity to both a `BF_DoorBarricade` and a `BF_DoubleDoorBarricade` to check whether the parent is one of these types. It then attempts to get the inventory of both cast objects, one of which is always guaranteed to be null. However, the `GetInventory` method exists on the original `EntityAI` type, so there's no need to get the inventory via the cast objects, and it only needs to be called once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Dumpgrah For your consideration, this PR fixes a "NULL pointer to instance" error when unlocking a combination lock that is attached to a Building Fortifications door.