192-fix-inverted-strike - #193
Open
caspercasanova wants to merge 1 commit into
Open
Conversation
jlkramer16
reviewed
Feb 15, 2024
| strikeQuoteAtomsPerLot: strike.toNumber(), | ||
| }); | ||
|
|
||
| if (!isUSDCQuotePair(baseMint, quoteMint)) { |
Contributor
There was a problem hiding this comment.
Preferred solution would be to modify isUpsidePool() if neither base or quote contains USDC. The issue is that non-USDC quote assets flag that the pool is a "downside" or put and to invert the strike when it shouldn't
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added USDC pair check + Inversion of quote
Changed
dollarizefunction params to includesigFigamountChanged
strikeQuoteAtomsPerBaseTokento string for dollarized conversion