tui: add display settings editor (scale/rotation) - #5
Merged
Merged
Conversation
change these anywhere in the app Neither the GUI's drag canvas nor the TUI's arrow-key arrange screen ever exposed scale or transform (rotation) -- only position. Changing either required hand-editing a profile JSON or dropping to raw swaymsg. Several real profiles need transform (the vertical Dell P2422H in Alissons.conf) or per-desk scale tuning, with no in-app way to set either. Extended verify_output_state() with want_scale/want_transform first -- it previously only checked mode/position, so a caller changing scale or transform had no real confirmation the WM actually applied it versus just accepting the IPC command (the exact class of bug this whole tool exists to catch, now covered for this new case too). Confirmed live end-to-end via tmux: DP-2 scale 1.5->1.2, transform normal->270, applied and verified, matched exactly by real swaymsg state. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQoWkiW647dBgJ3NJxk4vu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fills a real gap: neither the GUI's drag canvas nor the TUI's arrow-key arrange screen ever exposed scale or transform (rotation) -- only position. Several real profiles need transform (the vertical Dell P2422H in Alissons.conf) or per-desk scale tuning, with no in-app way to set either until now.
Also extends
verify_output_state()withwant_scale/want_transform-- it previously only checked mode/position, so a caller changing scale/transform had no real confirmation the WM actually applied it vs. just accepting the IPC command.Confirmed live end-to-end via tmux (real PTY, no human needed): DP-2 scale 1.5->1.2, transform normal->270, applied and verified, matched exactly by real swaymsg state afterward. Reverted to correct state after the test.