Repository navigation
chore(site): give sitemap URLs the site's base path - #14
Merged
Merged
Conversation
TSC21
changed the title
TSC21
force-pushed
the
fix/docs-sitemap-urls
branch
from
October 2, 2026 13:32
3fdefc2 to
85b6184
Compare
TSC21
force-pushed
the
fix/docs-sitemap-urls
branch
from
October 2, 2026 14:07
85b6184 to
036f8ad
Compare
Every URL in the published sitemap leaves out /mavlink-military/, the path the site is served under, so each one returns 404 and search engines find no page that exists. config.mjs passes the sitemap a hostname without a trailing slash, and the sitemap resolves each page against it, which drops the last path segment: en/about/scope.html becomes https://dronecode.github.io/en/about/scope.html. The hostname gets its trailing slash in config.mjs, whatever DOCS_HOSTNAME holds, so the custom domain the config comment plans for can't bring the problem back. Validation: built with the docs workflow's environment, all 13 sitemap URLs start with https://dronecode.github.io/mavlink-military/ and name a page in the build; on main all 13 start with https://dronecode.github.io/en/. Built with no base path and another host, the URLs follow that host. Assisted-by: Claude-Code:claude-opus-5-5 Signed-off-by: TSC21 <nmarques@riis.com>
TSC21
force-pushed
the
fix/docs-sitemap-urls
branch
from
October 2, 2026 16:20
036f8ad to
bf0eadb
Compare
TSC21
changed the title
mrpollo
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every URL in the published sitemap is missing the
/mavlink-military/part of the address, so all of them return 404. This fixes the sitemap.The cause is in
docs/.vitepress/config.mjs: it gives the sitemap a hostname without a trailing slash, and resolving a page against that drops the last path segment, soen/about/scope.htmlturns intohttps://dronecode.github.io/en/about/scope.html. The config always gives the hostname its trailing slash, so the custom domain planned for later can't bring the problem back.Tested by building with the docs workflow's settings: all 13 sitemap URLs start with
https://dronecode.github.io/mavlink-military/and each names a page in the build, and a build with no base path and another host gives URLs on that host. There is no change to the dialect or the generated headers. #11 adds a CI check for this, which fails until this is merged.Assisted-by: Claude-Code:claude-opus-5-5