update battery min max value to better recreate app expierience#26
Open
Robert-Riedl wants to merge 1 commit intoDrolla:masterfrom
Open
update battery min max value to better recreate app expierience#26Robert-Riedl wants to merge 1 commit intoDrolla:masterfrom
Robert-Riedl wants to merge 1 commit intoDrolla:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, so i've wondered for a couple of days why my waveplus has "0%" battery but is still reporting its other values accurately.
So i've checked with the offical app and to my surprise the battery value there was 3% - and the other waveplus devices all had 100%, while my mqtt values were in the 20s and 30s.
So I've dug around in your code and found that you've defined rather high values for bat_min and bat_max.
I've changed them to 2.1 and 2.4 respectivly - tell me what you think.