Skip to content

fix(console): map LF back to CR for Windows SAC CMD #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xirren wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(console): map LF back to CR for Windows SAC CMD #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/src/main/cpp/console/commands/console.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,14 @@ void ConsoleCommand::console_attach(
warned = true;
}
} else {
// The tty line discipline still has ICRNL set (we only touch
// c_lflag above), so the Enter key arrives here as LF. Windows
// SAC accepts LF, but the CMD channel's console only treats CR
// as Enter, so map LF back to CR before it reaches the guest.
// Linux getty is unaffected: its ICRNL turns CR back into NL.
// Same fix as cloud-hypervisor#1770 / PR #1771.
for (ssize_t i = 0; i < n; i++)
if (buf[i] == '\n') buf[i] = '\r';
Json::Value write_req;
write_req["command"] = "vm_console_write";
write_req["vm_id"] = filter_vm;
Expand Down
Loading