Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# Changelog

## v1.9.2

### Fixed

- `added_at`, `created_at`, `recorded_at`, and `last_fetched` columns (`cards`, `users`, `collection_entries`, `decks`, `price_history`, `wishlist_entries`, `converted_currencies`) used `server_default=sa.text('now()')`, valid Postgres SQL but not a SQLite function, causing `sqlite3.OperationalError: unknown function: now()` on any insert that didn't explicitly set the timestamp (e.g. importing a card) when running on SQLite
- Migrations now use `sa.func.now()`, which SQLAlchemy compiles per dialect (`CURRENT_TIMESTAMP` on SQLite, `now()` on Postgres); new migration `c3d4e5f6a7b8` repairs existing SQLite databases in place via `batch_alter_table`, applied automatically on next `alembic upgrade head`

### Changed

- Version bumped from 1.9.1 to 1.9.2 within `constants.py`.

## v1.9.1

### Added
Expand Down
4 changes: 2 additions & 2 deletions backend/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@


VERSIONS = {
"API_VERSION": "1.9.1",
"APPLICATION_VERSION": "1.9.1",
"API_VERSION": "1.9.2",
"APPLICATION_VERSION": "1.9.2",
}

API_RATES = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def upgrade() -> None:
'price_history',
sa.Column('id', sa.Integer(), nullable=False),
sa.Column('card_id', sa.Integer(), nullable=False),
sa.Column('recorded_at', sa.DateTime(timezone=True), server_default=sa.text('now()'), nullable=True),
sa.Column('recorded_at', sa.DateTime(timezone=True), server_default=sa.func.now(), nullable=True),
sa.Column('price_usd', sa.Float(), nullable=True),
sa.Column('price_usd_foil', sa.Float(), nullable=True),
sa.Column('price_eur', sa.Float(), nullable=True),
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
"""fix now() server defaults for sqlite compatibility

Revision ID: c3d4e5f6a7b8
Revises: f1a2b3c4d5e6
Create Date: 2026-09-09

"""
from typing import Sequence, Union

from alembic import op
import sqlalchemy as sa


# revision identifiers, used by Alembic.
revision: str = 'c3d4e5f6a7b8'
down_revision: Union[str, Sequence[str], None] = 'f1a2b3c4d5e6'
branch_labels: Union[str, Sequence[str], None] = None
depends_on: Union[str, Sequence[str], None] = None

_COLUMNS = [
('cards', 'last_fetched'),
('users', 'created_at'),
('collection_entries', 'added_at'),
('decks', 'created_at'),
('price_history', 'recorded_at'),
('wishlist_entries', 'added_at'),
('converted_currencies', 'added_at'),
]


def upgrade() -> None:
for table, column in _COLUMNS:
with op.batch_alter_table(table) as batch_op:
batch_op.alter_column(
column,
existing_type=sa.DateTime(timezone=True),
existing_nullable=True,
server_default=sa.func.now(),
)


def downgrade() -> None:
for table, column in _COLUMNS:
with op.batch_alter_table(table) as batch_op:
batch_op.alter_column(
column,
existing_type=sa.DateTime(timezone=True),
existing_nullable=True,
server_default=sa.text('now()'),
)
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def upgrade() -> None:
sa.Column('code', sa.String(10), nullable=False),
sa.Column('symbol', sa.String(10), nullable=False),
sa.Column('rate', sa.Float(), nullable=True),
sa.Column('added_at', sa.DateTime(timezone=True), server_default=sa.text('now()'), nullable=True),
sa.Column('added_at', sa.DateTime(timezone=True), server_default=sa.func.now(), nullable=True),
sa.Column('rate_updated_at', sa.DateTime(timezone=True), nullable=True),
sa.PrimaryKeyConstraint('id'),
sa.UniqueConstraint('code', name='uq_converted_currency_code'),
Expand Down
8 changes: 4 additions & 4 deletions backend/migrations/versions/ede0c3064869_initial_schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def upgrade() -> None:
sa.Column('price_usd', sa.Float(), nullable=True),
sa.Column('price_usd_foil', sa.Float(), nullable=True),
sa.Column('price_eur', sa.Float(), nullable=True),
sa.Column('last_fetched', sa.DateTime(timezone=True), server_default=sa.text('now()'), nullable=True),
sa.Column('last_fetched', sa.DateTime(timezone=True), server_default=sa.func.now(), nullable=True),
sa.PrimaryKeyConstraint('id')
)
op.create_index(op.f('ix_cards_id'), 'cards', ['id'], unique=False)
Expand All @@ -52,7 +52,7 @@ def upgrade() -> None:
sa.Column('hashed_password', sa.String(length=255), nullable=False),
sa.Column('is_active', sa.Boolean(), nullable=True),
sa.Column('is_admin', sa.Boolean(), nullable=True),
sa.Column('created_at', sa.DateTime(timezone=True), server_default=sa.text('now()'), nullable=True),
sa.Column('created_at', sa.DateTime(timezone=True), server_default=sa.func.now(), nullable=True),
sa.PrimaryKeyConstraint('id'),
sa.UniqueConstraint('email')
)
Expand All @@ -67,7 +67,7 @@ def upgrade() -> None:
sa.Column('condition', sa.String(length=10), nullable=True),
sa.Column('language', sa.String(length=10), nullable=True),
sa.Column('notes', sa.Text(), nullable=True),
sa.Column('added_at', sa.DateTime(timezone=True), server_default=sa.text('now()'), nullable=True),
sa.Column('added_at', sa.DateTime(timezone=True), server_default=sa.func.now(), nullable=True),
sa.ForeignKeyConstraint(['card_id'], ['cards.id'], ),
sa.ForeignKeyConstraint(['user_id'], ['users.id'], ),
sa.PrimaryKeyConstraint('id'),
Expand All @@ -81,7 +81,7 @@ def upgrade() -> None:
sa.Column('format', sa.String(length=50), nullable=True),
sa.Column('description', sa.Text(), nullable=True),
sa.Column('is_public', sa.Boolean(), nullable=True),
sa.Column('created_at', sa.DateTime(timezone=True), server_default=sa.text('now()'), nullable=True),
sa.Column('created_at', sa.DateTime(timezone=True), server_default=sa.func.now(), nullable=True),
sa.Column('updated_at', sa.DateTime(timezone=True), nullable=True),
sa.ForeignKeyConstraint(['user_id'], ['users.id'], ),
sa.PrimaryKeyConstraint('id')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def upgrade() -> None:
sa.Column('target_price', sa.Float(), nullable=True),
sa.Column('foil', sa.Boolean(), nullable=True),
sa.Column('notes', sa.Text(), nullable=True),
sa.Column('added_at', sa.DateTime(timezone=True), server_default=sa.text('now()'), nullable=True),
sa.Column('added_at', sa.DateTime(timezone=True), server_default=sa.func.now(), nullable=True),
sa.ForeignKeyConstraint(['card_id'], ['cards.id'], ),
sa.ForeignKeyConstraint(['user_id'], ['users.id'], ),
sa.PrimaryKeyConstraint('id'),
Expand Down
Loading