Repository navigation
Conversation
A callable url that raises now backs off and retries with the same cap as a transport error. on_status exceptions still propagate, and tests pin reconnect, backoff, and client close. Co-authored-by: herklos.dev <herklos.dev@protonmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subscribe_changesresolved a callable URL outside the retry path, so a factory exception ended the subscription. That call now sits in the reconnect loop. A factory failure backs off and retries with the same cap ashttpx.HTTPErrorandOSError. Exceptions fromon_statusstill propagate. Backoff still resets when the connection opens (HTTP 2xx), not on the first frame. The docstring no longer says the generator never raises.Test plan
cd packages/python/client && uv run --python 3.12 --extra dev pytest(171 passed, including reconnect, backoff, non-2xx, URL re-resolution, client close, and the factory /on_statuscases)