Repository navigation
Conversation
The WAL clock tie-break and stableStringify key sort were the same function. WAL now calls the protocol export, so the two orders cannot drift. Co-authored-by: herklos.dev <herklos.dev@protonmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WAL clock tie-break and
stableStringifykey sort were the same Unicode code-point comparison, copied inpackages/ts/wal/src/clock.tsand kept private inpackages/ts/protocol/src/hash.ts.compareCodePointsis now exported from@drakkar.software/starfish-protocol. The WAL imports that function and re-exports it, socompareClocksand existing WAL callers keep the same results. Python needs no twin:sorted()is already code-point order.No lockfile change.
CHANGELOG.mdis left untouched because other open pull requests already edit it.Tests
pnpm --filter @drakkar.software/starfish-protocol test(248 passed) andtypecheckpnpm --filter @drakkar.software/starfish-wal test(77 passed) andtypecheck