Repository navigation
Conversation
join_node_by_link built a space entry and then ignored it, so a whitespace-only nodeName was stored raw. The spaces list now uses the name build_space produces. Co-authored-by: herklos.dev <herklos.dev@protonmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
join_node_by_linkbuilt a space withbuild_spaceand then stored the rawnodeNameinstead. A whitespace-only name is now saved as the namebuild_spaceproduces (space-plus the last six characters of the node id). Thebuild_spacedocstring matches that behavior.TypeScript
joinNodeByLinkalready stores thebuildSpaceentry, so this change is Python only.Test plan
cd packages/python/spaces && uv run --python 3.12 --extra dev pytest(245 passed, including the blank-name regression)