Repository navigation
Conversation
The package catalog called events TypeScript-only and left it out of the package table and trees. Python usage snippets imported modules that are not in the tree. Point those snippets at starfish_server and starfish_server.router. Co-authored-by: herklos.dev <herklos.dev@protonmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
starfish-events, and the count sentence called it TypeScript-only. Bothpackages/ts/eventsandpackages/python/eventsexist.webhookstays the only TypeScript-only package.packages/python/events/README.mdandwebsite/docs/analytics/events.mdimportedstarfish_server.router.sync_routerandstarfish_protocol.config. Those modules are not in the tree. The snippets now importCollectionConfigandSyncConfigfromstarfish_server, andSyncRouterOptionsandcreate_sync_routerfromstarfish_server.router.CLAUDE.mdlists both events packages in the repository tree.Test plan
create_sync_routerandSyncRouterOptionsare exported fromstarfish_server.routerSyncConfigandCollectionConfigare exported fromstarfish_serverstarfish_server.router.sync_routerandstarfish_protocol.configare not modules