Repository navigation
Conversation
Remove unused json, StrEnum, and encryption-mode imports, and drop the f prefix on validation errors that have no placeholders. The error text is unchanged. Co-authored-by: herklos.dev <herklos.dev@protonmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsonin the loader, andStrEnum,ENCRYPTION_NONE, andENCRYPTION_DELEGATEDin the schema.fprefix on three validation error strings that contain no placeholders. The error text is the same.Ruff 0.17.0 with rules E4, E7, E9, and F on the two touched files: 7 findings before, 0 after.
uv run --python 3.12 --extra dev pytestinpackages/python/server: 790 passed, 35 deselected.Test plan
ruff check0.17.0 onstarfish_server/config/loader.pyandstarfish_server/config/schema.py--extra dev)