Skip to content

Add informational ruff lint job for Python packages - #89

Open
Herklos wants to merge 2 commits into
masterfrom
cursor/ruff-ci-lint-job-1ffc
Open

Herklos wants to merge 2 commits into
masterfrom
cursor/ruff-ci-lint-job-1ffc

Conversation

@Herklos

@Herklos Herklos commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a root ruff.toml for the Python packages. It targets py311 and enables only the E4, E7, E9 and F rule groups. Tests and examples/ are excluded.
  • Add a lint job to .github/workflows/publish-python.yml. It runs on pull requests and on pushes to master, uses Python 3.12, and runs ruff pinned to 0.17.0 over packages/python.
  • The ruff step uses continue-on-error: true, so the job reports findings without failing the check. The job does not appear in the needs of any publish job, so it does not gate publishing.
  • Remove the # noqa: F821 on the ExceptionGroup raise in mirror_channel.py. ExceptionGroup is a builtin on Python 3.11 and later, so the comment suppressed nothing.

Notes

  • The current tree has 60 ruff findings (48 unused imports, 6 late imports, 3 unused variables, 3 f-strings without placeholders). Fixing them is out of scope for this PR and will come in a follow-up.
  • No dependency files or lockfiles changed. Ruff is pinned in the workflow only.
  • The test matrix is unchanged.
Open in Web Open in Cursor 

cursoragent and others added 2 commits October 13, 2026 13:44
Add a root ruff.toml (target py311, rules E4, E7, E9, F; tests and
examples excluded) and a lint job in publish-python.yml that runs
ruff 0.17.0 on Python 3.12 over packages/python. The job is
informational: the ruff step uses continue-on-error, and the job
does not gate the publish jobs.

Co-authored-by: herklos.dev <herklos.dev@protonmail.com>
ExceptionGroup is a builtin on Python 3.11 and later, which the
package requires, so the noqa comment no longer suppresses anything.

Co-authored-by: herklos.dev <herklos.dev@protonmail.com>
@Herklos Herklos self-assigned this Oct 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants