Repository navigation
Conversation
Add a root ruff.toml (target py311, rules E4, E7, E9, F; tests and examples excluded) and a lint job in publish-python.yml that runs ruff 0.17.0 on Python 3.12 over packages/python. The job is informational: the ruff step uses continue-on-error, and the job does not gate the publish jobs. Co-authored-by: herklos.dev <herklos.dev@protonmail.com>
ExceptionGroup is a builtin on Python 3.11 and later, which the package requires, so the noqa comment no longer suppresses anything. Co-authored-by: herklos.dev <herklos.dev@protonmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff.tomlfor the Python packages. It targetspy311and enables only theE4,E7,E9andFrule groups. Tests andexamples/are excluded.lintjob to.github/workflows/publish-python.yml. It runs on pull requests and on pushes tomaster, uses Python 3.12, and runs ruff pinned to0.17.0overpackages/python.continue-on-error: true, so the job reports findings without failing the check. The job does not appear in theneedsof any publish job, so it does not gate publishing.# noqa: F821on theExceptionGroupraise inmirror_channel.py.ExceptionGroupis a builtin on Python 3.11 and later, so the comment suppressed nothing.Notes