Repository navigation
Conversation
Drop export keywords from identities directory helpers and cap-mint constants, remove the unused keyring _SEAL_EPOCH export, and keep the replica scheduler default error handler internal. Public package entry points are unchanged. Co-authored-by: herklos.dev <herklos.dev@protonmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
The identities, directory, and replica helpers were not on the package entry points, and nothing in the repo imports them. Dropping those exports is safe.
One leftover in keyring: the comment above toBytes still says the following symbol is exported for tests and cross-language checks. That symbol was _SEAL_EPOCH, which this change removes. toBytes is private and is not part of the seal format. Delete that comment.
Sent by Cursor Automation: Review
Co-authored-by: herklos.dev <herklos.dev@protonmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knip flagged several TypeScript symbols that were exported from source files but not re-exported from package entry points. This change drops those exports so the helpers stay module-private, matching patterns already used in
@drakkar.software/starfish-sharing.Touched packages: identities (cap-mint constants and directory helpers), keyring (unused
_SEAL_EPOCHexport), replica (default scheduler error handler). Public package APIs are unchanged.Ran vitest for identities, keyring, and replica (300 tests).