Skip to content
This repository was archived by the owner on Feb 21, 2026. It is now read-only.

Init DSL - #1638

Merged
GuillaumeDSM merged 2 commits into
devfrom
dsl
Nov 19, 2025
Merged

GuillaumeDSM merged 2 commits into
devfrom
dsl

Conversation

@GuillaumeDSM

@GuillaumeDSM GuillaumeDSM commented Nov 14, 2025 •

Copy link
Copy Markdown
Member

@GuillaumeDSM
GuillaumeDSM requested a review from Herklos November 14, 2025 21:47
@GuillaumeDSM GuillaumeDSM self-assigned this Nov 14, 2025
@GuillaumeDSM GuillaumeDSM changed the title Init DSL WIP Init DSL Nov 14, 2025
@GuillaumeDSM GuillaumeDSM changed the title WIP Init DSL Init DSL Nov 17, 2025

@Herklos Herklos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation 👍

{
"version": "1.2.0",
"origin_package": "OctoBot-Default-Tentacles",
"tentacles": [],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tentacles classes are missing here

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tentacle classes here, I don't think we want to list all DSL operators here (this list is used to enable/disable tentacles, it's not relevants for dsl operators)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👍

Comment on lines +30 to +34
("rsi", ["", "(close)", "(close, 14, 20)"]),
("macd", ["", "(close)", "(close, 'a')", "(close, 'a', 26)", "('a', 14, 26, 9, 0)"]),
("ma", ["", "(close)", "(close, 14, 20)"]),
("ema", ["", "(close)", "(close, 14, 20)"]),
("vwma", ["", "(close)", "('a', 14)", "(close, 'a')", "(close, 14, 11, 20)"]),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return "macd"

@staticmethod
def get_parameters() -> list[dsl_interpreter.OperatorParameter]:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


def compute(self) -> dsl_interpreter.ComputedOperatorParameterType:
computed_parameters = self.get_computed_parameters()
return commons_enums.TimeFramesMinutes[commons_enums.TimeFrames(computed_parameters[0])] * commons_constants.MINUTE_TO_SECONDS

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuillaumeDSM
GuillaumeDSM enabled auto-merge (rebase) November 19, 2025 09:51
@GuillaumeDSM
GuillaumeDSM merged commit 8d5a42b into dev Nov 19, 2025
5 checks passed
@GuillaumeDSM
GuillaumeDSM deleted the dsl branch November 19, 2025 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants