Repository navigation
fix: verify M5Burner publication state - #6
Merged
Merged
Conversation
Add a beginner-friendly phone provisioning guide and a verified SD config template. Clarify offline use, SD card paths, file naming, and the fact that M5Burner does not configure WiFi automatically.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Prepare the publisher for v3.1.0 and describe the phone provisioning flow.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Handle the API response where an already-published version returns HTTP 400, and verify the authoritative version list before reporting success.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_4a5a13e9-94cd-46c0-bfc3-7415bd5faee9) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle M5Burner API 400 responses for already-published versions and verify the authoritative version list before reporting success.
Note
Medium Risk
Large firmware changes to WiFi boot path, credential persistence (NVS/SD), and an always-on HTTP/DNS stack during setup; publish script changes affect release automation but not device runtime beyond new binaries.
Overview
Adds phone-first WiFi provisioning on the device: SoftAP
PaperColor-XXXXXX, captive portal athttp://192.168.4.1, scan/save/connect flow, on-screen QR (ricmoo/QRCode), and credentials in NVS + optional SDconfig.ini(script#CFGDONEclears NVS so SD wins). Entry via boot with no creds, QR page long-press B, or serial#WIFIAP; C = offline mode persisted in NVS.Boot behavior now sets
wifiReconnectPendingwhen stored creds exist (so it connects without waiting for standby wake); otherwise auto-starts setup unless offline mode is set. Main loop blocks standby/reconnect/polling whilewifiSetupActive.Docs/onboarding:
docs/m5burner-quick-start.md,config.ini.example, README/CHANGELOG emphasize M5Burner burn → phone setup (SD optional).publish_m5burner.py: bumps to v3.1.0, uploads a new firmware version when the listed version differs (update_firmware), treats publish 400 as OK if the firmware list shows the version already published, and updates store copy for phone provisioning.Reviewed by Cursor Bugbot for commit 80085b2. Bugbot is set up for automated code reviews on this repo. Configure here.