Repository navigation
feat(web): brand the demo login dialog and make its rows clickable - #1581
Merged
Merged
Conversation
Show the logo and product name at the top of the demo information dialog, matching the site title on opendatacapture.org. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The login icon was the only target in each row of the demo credentials dialog, so picking an account meant aiming at a 36px button rather than at the account being read. The row now carries the handler and the icon keeps none of its own, so its activation bubbles to the row: one path into `onLogin` whether it is reached by pointer or by keyboard. The header row cancels the hover highlight `Table.Row` applies by default, since only a body row is clickable. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
thomasbeaudry
changed the title
…serts it `backgroundColorWhileHovering` took any locator and never touched `this`, so it was a free function sitting among the page object's own interactions. The spec that needs it now hovers and reads the colour itself, and the header row's locator is named for the table rather than for the users. Also moves the trigger comment in `DemoBanner` out of the Radix tooltip root, where it was a child expression, and states the invariant it is there for. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to the demo credentials dialog on the login page.
Branding. The dialog now opens with the Open Data Capture logo and name, matching the site title in the top-left of opendatacapture.org (
apps/outreach/src/components/common/SiteTitle.astro). It reusesLogofrom@opendatacapture/react-core, which is the same mark. The name is set larger than the dialog's "Demo Information" title, with extra space between the two.Clickable rows. The login icon was the only target in each row, so picking an account meant aiming at a 36px button rather than at the account being read. The row now carries the handler and the icon keeps none of its own, so its activation bubbles to the row — one path into
onLoginwhether it is reached by pointer or by keyboard, and no second tab stop. The header row cancels the hover highlightTable.Rowapplies by default, since only a body row is clickable.Verification
apps/web/src/__tests__/demo-banner.test.tsx— the dialog carries the logo and the product name; a click on any cell logs in as that row's user; a click on the icon firesonLoginexactly once.testing/src/specs/auth.spec.ts› demo instance — branding, login from the row itself, and the header row not highlighting on hover.Co-Authored-By: Claude Opus 5 noreply@anthropic.com
🤖 Generated with Claude Code