Skip to content

Add furlough.ai.custom-domain template#1177

Draft
RogueZach wants to merge 1 commit into
Domain-Connect:masterfrom
RogueZach:add-furlough-custom-domain
Draft

Add furlough.ai.custom-domain template#1177
RogueZach wants to merge 1 commit into
Domain-Connect:masterfrom
RogueZach:add-furlough-custom-domain

Conversation

@RogueZach
Copy link
Copy Markdown

Description

Adds furlough.ai.custom-domain.json — a new Domain Connect template for Furlough
(white-label sign-in for engineering-org analytics). It points a customer's chosen
sign-in subdomain at Furlough's Cloudflare-for-SaaS edge with a single CNAME
(<host> CNAME proxy.furlough.ai). Synchronous signed flow only.

providerId furlough.ai · serviceId custom-domain.

Type of change

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

  • Template functionality checked using Online Editorlink pending (see below); draft until added
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver — https://app.furlough.ai/logo.svg returns 200 + content-type: image/svg+xml

Also validated locally with dc-template-linter: default run and -merge-or-fail both exit 0. The two -cloudflare notes (DCTL5006 hostRequired not supported, DCTL5007 CNAME-flattening) are info-level and expected for a subdomain CNAME.

Checklist of common problems

  • syncPubKeyDomain is set (furlough.ai)
  • warnPhishing is not set alongside syncPubKeyDomain
  • syncRedirectDomain set whenever redirect_uri is used — N/A, template uses no redirect_uri (synchronous signed flow only)
  • no TXT record contains SPF content — N/A, no TXT records
  • txtConflictMatchingMode set on unique TXT records — N/A, no TXT records
  • no variable used as a bare full record value — N/A, template has no variables
  • no bare variable used as the full host label — N/A, no variables
  • no variable used in host to create a subdomain — correct; the subdomain comes from the host request parameter (hostRequired: true)
  • %host% does not appear explicitly in any host attribute — correct; host is @
  • essential set to OnApply where the user may modify/remove a record — N/A; the single CNAME is the service itself (removing it disconnects the domain)

Online Editor test results

With hostRequired: true, the apex test is exempt per the template note — a single subdomain (host-set) test suffices.

Editor test link(s):

Single CNAME (<host> -> proxy.furlough.ai) for Furlough white-label custom
sign-in domains. Synchronous signed flow; hostRequired so the record always
lands on the requested subdomain. Lint-clean (dc-template-linter default and
-merge-or-fail exit 0).
@github-actions github-actions Bot added hostRequired hostRequired is set PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Jun 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

JSON Filename Check Passed

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  Checklist of common problems: 10/10 checkboxes ticked

Labels to add: PR description incomplete, Test links missing
Labels to remove: Checklist of common problems not complete, Forged editor links

PR description check FAILED:
  FAIL  'How Has This Been Tested?': 1/3 checkboxes are not ticked
  FAIL  'Online Editor test results': no valid editor test link found
  FAIL  Template coverage: furlough.ai.custom-domain.json: no editor test link found (expected template id 'furlough.ai.custom-domain')

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

JSON Schema Validation Passed

@github-actions github-actions Bot added the automerge-possible Label indicating, that restrictive linter checks all pass. For now it's PoC. label Jun 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Linter OK

furlough.ai.custom-domain.json

Level Code Note

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge-possible Label indicating, that restrictive linter checks all pass. For now it's PoC. hostRequired hostRequired is set PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant