Add furlough.ai.custom-domain template#1177
Draft
RogueZach wants to merge 1 commit into
Draft
Conversation
Single CNAME (<host> -> proxy.furlough.ai) for Furlough white-label custom sign-in domains. Synchronous signed flow; hostRequired so the record always lands on the requested subdomain. Lint-clean (dc-template-linter default and -merge-or-fail exit 0).
|
✅ JSON Filename Check Passed |
PR Description Check FailedThe PR description is missing required elements. Please update it according to the PR template. Details |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
furlough.ai.custom-domain.json— a new Domain Connect template for Furlough(white-label sign-in for engineering-org analytics). It points a customer's chosen
sign-in subdomain at Furlough's Cloudflare-for-SaaS edge with a single CNAME
(
<host> CNAME proxy.furlough.ai). Synchronous signed flow only.providerId
furlough.ai· serviceIdcustom-domain.Type of change
How Has This Been Tested?
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserver —https://app.furlough.ai/logo.svgreturns200+content-type: image/svg+xmlAlso validated locally with
dc-template-linter: default run and-merge-or-failboth exit0. The two-cloudflarenotes (DCTL5006hostRequired not supported, DCTL5007 CNAME-flattening) are info-level and expected for a subdomain CNAME.Checklist of common problems
syncPubKeyDomainis set (furlough.ai)warnPhishingis not set alongsidesyncPubKeyDomainsyncRedirectDomainset wheneverredirect_uriis used — N/A, template uses noredirect_uri(synchronous signed flow only)txtConflictMatchingModeset on unique TXT records — N/A, no TXT recordshostlabel — N/A, no variableshostto create a subdomain — correct; the subdomain comes from thehostrequest parameter (hostRequired: true)%host%does not appear explicitly in anyhostattribute — correct;hostis@essentialset toOnApplywhere the user may modify/remove a record — N/A; the single CNAME is the service itself (removing it disconnects the domain)Online Editor test results
Editor test link(s):