refactor: delete filters through the REST endpoint

package.json

@@ -53,7 +53,7 @@
   ],
   "dependencies": {
     "@doist/cli-core": "1.7.0",
-    "@doist/todoist-sdk": "15.7.0",
+    "@doist/todoist-sdk": "15.8.0",
     "@napi-rs/keyring": "2.1.1",
     "@pnpm/tabtab": "0.5.4",
     "chalk": "6.0.1",

src/lib/api/core.ts

@@ -124,6 +124,8 @@ const API_SPINNER_MESSAGES: Record<string, { text: string; color?: 'blue' | 'gre
         addFolder: { text: 'Creating folder...', color: 'green' },
         updateFolder: { text: 'Updating folder...', color: 'yellow' },
         deleteFolder: { text: 'Deleting folder...', color: 'yellow' },
+        // Filters
+        deleteFilter: { text: 'Deleting filter...', color: 'yellow' },
     }
 
 function createSpinnerWrappedApi(api: TodoistApi): TodoistApi {

src/lib/api/filters.test.ts

@@ -0,0 +1,25 @@
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+vi.mock('./core.js', () => ({
+    getApi: vi.fn(),
+}))
+
+import { setupApiMock } from '../../test-support/api-mock.js'
+import type { MockApi } from '../../test-support/mock-api.js'
+import { deleteFilter } from './filters.js'
+
+describe('deleteFilter', () => {
+    let mockApi: MockApi
+
+    beforeEach(() => {
+        vi.clearAllMocks()
+        mockApi = setupApiMock()
+    })
+
+    it('deletes the filter through the REST endpoint', async () => {
+        await deleteFilter('filter-123')
+
+        expect(mockApi.deleteFilter).toHaveBeenCalledWith('filter-123')
+        expect(mockApi.sync).not.toHaveBeenCalled()
+    })
+})

src/lib/api/filters.ts

@@ -84,7 +84,5 @@ export async function updateFilter(id: string, args: UpdateFilterArgs): Promise<
 
 export async function deleteFilter(id: string): Promise<void> {
     const api = await getApi()
-    await api.sync({
-        commands: [createCommand('filter_delete', { id })],
-    })
+    await api.deleteFilter(id)
 }

src/test-support/mock-api.ts

@@ -210,6 +210,8 @@ export function createMockApi(overrides: Partial<TodoistApi> = {}): MockApi {
         addFolder: vi.fn(),
         updateFolder: vi.fn(),
         deleteFolder: vi.fn().mockResolvedValue(true),
+        // Filters
+        deleteFilter: vi.fn().mockResolvedValue(true),
         ...overrides,
     } as unknown as MockApi
 }