Repository navigation
fix: send explicit Status field and effect removals - #96
Merged
Merged
Conversation
enricenrich
marked this pull request as ready for review
October 28, 2026 17:33
doistbot
reviewed
Oct 28, 2026
doistbot
left a comment
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR updates tdc status set to match the new partial-update contract: omitted emoji, expiration, and known pause effects are sent as explicit null (or cleared) while supported effects are enabled with {}, preserving unsupported values. The SDK pin, tests, help text, and generated skill reference are all updated consistently, and clearing the full status still uses the dedicated endpoint.
Few things worth tightening:
--dry-runnow under-reports whatsetwill do: since omitted emoji/expiry/pause flags are sent asnulland clear existing values, a preview liketdc status set "Away" --dry-runshould surface those removals (e.g.Emoji: cleared,Pause notifications: cleared) instead of only showing the explicitly supplied flags.
Member
Author
|
@scottlovegrove, I've assigned this PR to you because of the context on the SDK changes. After this I'll assign it to the expected group. |
enricenrich
added
the
🙋 Ask
scottlovegrove
approved these changes
Oct 28, 2026
doist-release-bot Bot
added a commit
that referenced
this pull request
Oct 28, 2026
## [3.8.1](v3.8.0...v3.8.1) (2026-10-28) ### Bug Fixes * send explicit Status field and effect removals ([#96](#96)) ([63135a9](63135a9))
Contributor
|
🎉 This PR is included in version 3.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the new backend contract, omitted Status values remain unchanged. Keep
tdc status setreplacing the fields it supports by sending explicitnullfor omitted emoji, expiration and disabled known effects. Enable effects with{}so existing configuration is preserved or backend defaults are applied. Fields and effects the CLI does not support remain unchanged.Update the existing command tests, help and generated skill reference to describe this behavior. Clearing the entire Status continues to use the dedicated endpoint.
Dependency
The companion SDK change is released in
@doist/comms-sdk@3.9.1. This PR updates the dependency pin and lockfile to use the published SDK.Validation
npm ciusing the published SDK.Reference