Fix real-stack journey for full-page game details by Doezer · Pull Request #1232 · Doezer/Questarr

Doezer · 2026-10-21T13:10:44Z

Requested by Vincent · project thread

Summary

The "Real stack" workflow has failed on main (scheduled run on Oct 19) and on Bump the all-actions group with 7 updates #1218 since the game details became a full page (/games/:id). It last passed on Oct 13.
grabFromLibrary still waited for a Download button inside a dialog; the button now sits on the game page, so the qBittorrent journey hung until the 6-minute test timeout (locator.click: Target page, context or browser has been closed).
Click the button by its existing data-testid="button-download-game" instead.

Test plan

npx tsc passes
"Real stack" workflow passes on this PR (qbittorrent, transmission and sabnzbd journeys). I couldn't run it locally: qbittorrent-nox, transmission and sabnzbd aren't installed in this sandbox.

Test-only change, no client/src/** changes.

Generated by Claude Code

Summary by CodeRabbit

Tests
- Updated download flow coverage to open the game download dialog through the game page’s download control.
- Retained existing release-selection and download verification checks.

The game card now opens /games/:id instead of a dialog, so the journey waited for a dialog Download button that no longer exists. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015Cn1mSE6XssBjmbjKPa2wY

chatgpt-codex-connector · 2026-10-21T13:10:55Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-21T13:11:31.717459Z	`8612bb7`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-21T13:11:01Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: b4e16f10-d7e9-4f81-a527-c24475f982f9

📥 Commits

Reviewing files that changed from the base of the PR and between cf83063 and 8612bb7.

📒 Files selected for processing: 1

tests/stack/real-stack.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The real-stack test now uses the game page’s button-download-game test ID to open the download dialog. Its release-selection and download checks remain unchanged.

Changes: Download dialog

Layer / File(s)	Summary
Open download dialog `tests/stack/real-stack.spec.ts`	`grabFromLibrary` clicks the game page’s `button-download-game` test ID instead of locating a “Download” button inside a dialog.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: claude

Merge Risk: ⚪ Minimal · up to 8612b

The updated journey follows the full-page game-details flow without an identified merge-blocking risk.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the main change: updating the real-stack journey for the full-page game details UI.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

sonarqubecloud · 2026-10-21T13:11:25Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

gitar-bot · 2026-10-21T13:12:07Z

Code Review ✅ Approved

🟢 Low risk · This only updates a real-stack test's download-button locator for the full-page game UI; application behavior and interfaces are unchanged.

Updates the Real stack journey test helper to click the game page's data-testid="button-download-game" button directly, instead of waiting for a Download button inside a dialog that no longer exists since game details became a full page. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

_{For more verification details, comment gitar display:verbose.}

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

`Auto-apply`	`Compact`
`gitar auto-apply:on`	`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source}

Doezer · 2026-10-21T13:12:49Z

wshm · Automated triage by AI

📊 Automated PR Analysis


🐛 Type	`bug-fix`
🟢 Risk	`low`

Summary

Fixes a broken Playwright test helper (grabFromLibrary) in the real-stack e2e test suite, updating it to click the download button via its data-testid now that game details moved from a dialog to a full page (/games/:id). This resolves the hanging/timeout failures seen in the scheduled 'Real stack' workflow since Oct 19.

Review Checklist

Tests present
Breaking change
Docs updated

Linked issues: #1218

Analyzed automatically by wshm · This is an automated analysis, not a human review.

codecov · 2026-10-21T13:16:33Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Doezer self-assigned this Oct 21, 2026

Doezer added bug-fix ci tests labels Oct 21, 2026

coderabbitai Bot approved these changes Oct 21, 2026

View reviewed changes

Doezer merged commit fe9f430 into main Oct 22, 2026
19 checks passed

Doezer deleted the claude/project-thread-qujhit branch October 22, 2026 03:09

Navigation Menu

Repository navigation

Fix real-stack journey for full-page game details - #1232

Fix real-stack journey for full-page game details#1232
Doezer merged 1 commit into
mainfrom
claude/project-thread-qujhit

Doezer commented Oct 21, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Oct 21, 2026

Uh oh!

gitar-bot Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

Doezer commented Oct 21, 2026

Uh oh!

codecov Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Doezer commented Oct 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

chatgpt-codex-connector Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Oct 21, 2026

Quality Gate passed

Uh oh!

gitar-bot Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Doezer commented Oct 21, 2026

📊 Automated PR Analysis

Summary

Review Checklist

Uh oh!

codecov Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Doezer commented Oct 21, 2026 •

edited by coderabbitai Bot

Loading

chatgpt-codex-connector Bot commented Oct 21, 2026 •

edited

Loading

coderabbitai Bot commented Oct 21, 2026 •

edited

Loading

gitar-bot Bot commented Oct 21, 2026 •

edited

Loading

codecov Bot commented Oct 21, 2026 •

edited

Loading