SOV-5278: estimated amm weekly rewards #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5527c5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for sovryn-dapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for sovryn-storybook canceled.
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the AMM weekly rewards estimation calculation to use more accurate data sources and improves the implementation by migrating to React Query for better data fetching patterns.
Changes:
- Refactored
useGetReturnRatehook from useState/useEffect pattern to React Query - Updated
useGetPoolBalanceAndRewardsto calculate weekly rewards using actual return rates instead of a fixed constant - Added support for both V1 and V2 pool types with different calculation methods
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/frontend/src/utils/graphql/rsk/operations/getToken.graphql | Added symbol field to token query |
| apps/frontend/src/utils/graphql/rsk/generated.tsx | Generated TypeScript types for the updated GraphQL query |
| apps/frontend/src/app/5_pages/MarketMakingPage/hooks/useGetReturnRate.ts | Migrated from useState/useEffect to React Query pattern |
| apps/frontend/src/app/5_pages/MarketMakingPage/components/PoolsTable/components/PoolsTableReturns/PoolsTableReturns.tsx | Updated to match new return signature of useGetReturnRate |
| apps/frontend/src/app/5_pages/MarketMakingPage/components/AdjustAndDepositModal/hooks/useGetPoolBalanceAndRewards.ts | Refactored to use dynamic APY-based rewards calculation with support for V1/V2 pools |
| apps/frontend/src/app/5_pages/MarketMakingPage/components/AdjustAndDepositModal/components/NewPoolStatistics/NewPoolStatistics.tsx | Updated function call to pass additional required parameters |
| .changeset/few-bugs-remember.md | Added changeset documenting the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...pages/MarketMakingPage/components/AdjustAndDepositModal/hooks/useGetPoolBalanceAndRewards.ts
Show resolved
Hide resolved
...pages/MarketMakingPage/components/AdjustAndDepositModal/hooks/useGetPoolBalanceAndRewards.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sovryn.atlassian.net/browse/SOV-5278