Fix unreadable preview overlay text in light mode - #9
Merged
Conversation
The asset-info overlay and the FMOD audio-player labels (status, frequency, channels, timer, copyright) are hardcoded white in the Designer for the dark preview background, so on the light theme they were white-on-light and unreadable. Theme their foreground in ApplyTheme with the mode's normal text color (near-white in dark, dark in light). Co-Authored-By: Clue Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In light ("clear") theme, the text in the preview area is white on a light background and unreadable — the asset-info overlay (
Compression format,Loop Start/End) and the FMOD audio player labels (Stopped,44100 Hz,Mono, the timer, and the "Audio Engine supplied by FMOD…" line).Cause
Those labels are hardcoded
ForeColor = Whitein the Designer (fine for the dark preview background) andApplyThemenever re-themed them, so they stayed white in light mode.Fix
Theme the overlay labels' foreground in
ApplyThemewith the mode's normal text color (near-white in dark, dark in light):assetInfoLabel,FMODstatusLabel,FMODinfoLabel,FMODtimerLabel,FMODaudioChannelsLabel,FMODcopyrightLabel.Verified