Port beneficial upstream AssetStudioMod PRs (#129/#130/#124/#113/#115) - #11
Merged
Conversation
Port of aelurum/AssetStudioMod#129: when a bone's frame isn't present in the exported hierarchy, FindFrameByPath returns null and _frameToNode[frame] threw a NullReferenceException. Skip that bone with an empty cluster instead. Co-Authored-By: Clue Opus 4.8 <noreply@anthropic.com>
…#130) Port of aelurum/AssetStudioMod#130: update the Linux/macOS/Windows native Texture2DDecoder runtime packages from 0.1.0 to 0.2.0. Restores and builds clean on net9. Co-Authored-By: Clue Opus 4.8 <noreply@anthropic.com>
…stream #124) Port of aelurum/AssetStudioMod#124: - Add --fbx-ascii-format flag (our FBX wrapper already supports FbxFormat/ascii). - Load AnimationClip in animator mode so --fbx-animation all can bind clips. - Allow --fbx-uvs-as-diffuse in animator mode too (was split-objects only). Co-Authored-By: Clue Opus 4.8 <noreply@anthropic.com>
Port of aelurum/AssetStudioMod#113: - --filter-exclude-mode inverts the filter (export everything that does NOT match). Clearer log wording than upstream (reports matched vs kept). - --strip-path-prefix strips a leading path from container paths when grouping by container / containerFull, validated against loaded containers. Co-Authored-By: Clue Opus 4.8 <noreply@anthropic.com>
Port of aelurum/AssetStudioMod#115: add an opt-in mode that places the cropped sprite onto a full-size canvas (the sprite's authored m_Rect) with transparent padding, so exports keep the original dimensions instead of the tight cropped region. Default off = unchanged (cropped) behavior. - SpriteHelper.GetImage gains a spriteWithCanvas param + CutImageWithCanvas. - CLI: --sprite-canvas flag. - GUI: "Export sprites at full canvas size" checkbox (Settings-backed). Co-Authored-By: Clue Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed the open PRs on aelurum/AssetStudioMod and ported the beneficial ones, adapted to our diverged codebase. Each is a separate commit.
_frameToNode[frame]NRE--fbx-ascii-format, load AnimationClips in animator mode, allow--fbx-uvs-as-diffusein animatorFbxFormat/ASCII--filter-exclude-mode,--strip-path-prefix--sprite-canvas+ GUI checkboxVerified
--filter-exclude-mode+--strip-path-prefix: tested on the samurai_oni sample — excludes matched assets and strips the container prefix as expected.--sprite-canvas: exported the sample's 9 sprites with/without the flag; untrimmed sprites are byte-for-byte unchanged (no regression). The padding path only differs for tightly-cropped sprites (none in this sample), so the visual padding wasn't exercised against a trimmed sprite.Notes