Skip to content

Implement the view-source menu-item from #363#364

Merged
nicoburns merged 2 commits intoDioxusLabs:mainfrom
mogambro:feature/view_source
Mar 5, 2026
Merged

Implement the view-source menu-item from #363#364
nicoburns merged 2 commits intoDioxusLabs:mainfrom
mogambro:feature/view_source

Conversation

@mogambro
Copy link
Contributor

@mogambro mogambro commented Mar 3, 2026

This allows to, well, view the source code of the current document.

Trade-Off: We store the entire source as a Signal ... an alternative would be to refetch it.

Screenshot from 2026-03-03 20-19-30 Screenshot from 2026-03-03 20-19-50

@mogambro mogambro force-pushed the feature/view_source branch 2 times, most recently from b07b9ef to c7246b1 Compare March 3, 2026 19:27
This allows to, well, view the source code of the current document.

Trade-Off: We store the entire source as a Signal<String> ... an
alternative would be to refetch it.
@mogambro
Copy link
Contributor Author

mogambro commented Mar 3, 2026

@nicoburns I think a retry of clippy should suffice

@mogambro mogambro requested a review from nicoburns March 5, 2026 14:45
@nicoburns nicoburns merged commit 1b3a575 into DioxusLabs:main Mar 5, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants