Repository navigation
Fix two translations that lost their %@ placeholder (pl, ca) - #2503
Merged
Merged
Conversation
|
This has been resolved for Catalan in PR #2499 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two strings in
Localizable.xcstringsdropped the%@, so the value never shows:%@ add-tag-groups.edit.title.field.warning.already-exists, Polish:już istnieje→%@ już istnieje(the tag name was missing from the warning)instance.list.posts-%@, Catalan:% publicacions→%@ publicacions(rendered a literal%)Separately, and not in this PR because it needs native speakers: 44 plural variations for Polish, Ukrainian and Belarusian only have
oneandother. Those languages also needfewandmany, so counts like 2, 3, 4 fall through to the wrong form. Happy to post the full list of keys as an issue if that's useful.Found these with a placeholder checker I've been building (polygo) and checked them by hand. Thanks for Ice Cubes.