Adds 304 support by hashing response body to create an ETag. - #1
Adds 304 support by hashing response body to create an ETag.#1davidwallacejackson wants to merge 1 commit into
Conversation
| return true; | ||
| } | ||
|
|
||
| response.header('Cache-Control', 'private, no-cache'); |
There was a problem hiding this comment.
There are a few spots in poseidon where we set private, no-cache, no-store, must-revalidate (doing a search for no-cache in dh2o-poseidon/src shows 4 files and a no_cache middleware that is applied to the entire app. Do any of these need to be changed?
I guess this line will correct that header if poseidon has set it to something else so maybe it doesn't matter.
|
One small request and one probably unnecessary question for further digging into poseidon. If you have a certain request in mind to test this out with let's get it into edge asap and see what the impact is. We need to get a tag on the current version of master then merge this and create a new tag, then get poseidon master to use that new tag. If things go well then we can include this in our upcoming release, if it needs more work then we will have the old tag to rollback for the release. LGTM for testing in edge |
|
also almost forgot 👍 😄 👯 🎂 👍 😄 👯 🎂 👍 😄 👯 🎂 👍 😄 👯 🎂 👍 😄 👯 🎂 👍 😄 👯 🎂 👍 😄 👯 🎂 👍 😄 👯 🎂 👍 😄 👯 🎂 👍 😄 👯 🎂 👍 😄 👯 🎂 👍 😄 👯 🎂 👍 😄 👯 🎂 👍 😄 👯 🎂 |
2 participants
@wescleveland