fix(explorer): label pending value transfers to contracts as the confirmed view does - #205
Merged
Merged
Conversation
…irmed view does The pending route attaches targetContract for any recipient with code, the confirmed route only when the transaction carries calldata. A plain value transfer to a verified contract therefore showed Contract call while pending and Transfer once mined. The classifier now counts targetContract only with calldata, so both views agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A plain value transfer to a verified contract showed Contract call on /pending/tx and Transfer on /tx once mined, because the pending route attaches targetContract for any recipient with code while the confirmed route requires calldata. getTransactionKind now counts targetContract only with calldata. Gates: jest 656/656, eslint, tsc.