Repository navigation
fix(money): keep negative allocation parts summing to the amount - #645
Merged
Merged
Conversation
Allocate(int parts) added the remainder cents only when the remainder was positive. A negative amount has a negative remainder, so the cents were dropped: -R100.00 in 3 parts summed to -R99.99. Remainder cents now move each part away from zero in the amount's direction, so -R100.00 gives -R33.34, -R33.33, -R33.33. Document this in the Money API reference. Implements #616 Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
DigiBanks99
enabled auto-merge (rebase)
November 15, 2026 05:58
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Money.Allocate(int parts)dropped the remainder cents for negative amounts, so -R100.00 in 3 parts summed to -R99.99.Acceptance criteria
GivenNegativeMoney_WhenAllocatingWithRemainderandGivenNegativeMoneyWithOddCents_WhenAllocatingWithRemainder. Both fail on the old code and pass with the fix.MoneyAllocationTests).docs/reference/money-api.mdsays how negative amounts are allocated.Verification:
dotnet teston Menlo.Lib.Tests passes (272/272).dotnet format --verify-no-changesis clean on the changed files.Closes #616
🤖 Generated with Claude Code