Skip to content

Conversation

@vincent1405
Copy link

Use:

Path.Combine(path, meta.WSDLFolder, wsdlfile)

instead of

path + Path.AltDirectorySeparatorChar + meta.WSDLFolder + Path.AltDirectorySeparatorChar + wsdlfile

Use Path.Combine to create a file path to WsdlFile.
@andersjonsson
Copy link
Collaborator

Thanks for the PR. Unfortunately, it doesn't build. Can you fix the errors please?

@zgabi
Copy link

zgabi commented Jan 17, 2026

This PR is wrong, please do not merge it.
WSDLFolder can be null, it should not be set to empty string.
Path.Combine does not work with nulls. Probably this is why he set the WSDLFolder to empty string... (And caused a lot of test fails)
The string concatenations works with nulls... there will be double path separators, which is not so nice, but it works with the file operations. (File.ReadAllText(@"C:\Git\1.txt") and File.ReadAllText(@"C:\Git\\1.txt") both works)

+1: There are 3 path string concatenations in this file, why just this line was "fixed"? :)

Maybe you can write a helper method which accepts null. But anyway I think this PR makes no sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants