Repository navigation
fix: bot-check advice and titles for failed videos - #1015
Merged
Merged
Conversation
When YouTube's bot check blocked a download on a server without cookies, Youtarr told the user to set cookies. The block is usually temporary and the videos download fine on the next scheduled run, so the messages now say that instead, and only suggest cookies if it keeps happening. Failed videos that Youtarr had never seen before showed only a YouTube id. They now show the title and channel, looked up through YouTube's public oEmbed endpoint.
Contributor
📊 Test Coverage ReportBackend Coverage
Frontend Coverage
Coverage Requirements
Coverage report generated for commit c59e0e0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When YouTube's bot check blocked a download on a server without cookies, Youtarr told the user to set cookies. The block is usually temporary and the videos download fine on the next scheduled run, so the messages now say that instead, and only suggest cookies if it keeps happening.
Failed videos that Youtarr had never seen before showed only a YouTube id. They now show the title and channel, looked up through YouTube's public oEmbed endpoint.