Task index: a slider that takes no focus on touch, and the ease that came out again (#182, #153) - #183
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two entries in the task index, no code.
#182, new — reported by Dawid from
the work form on a phone: with the cursor left in a text field, every move of an R360 slider
pulls the page back to that field.
Nothing puts the focus back — it never leaves. Measured in mobile Chromium (Pixel 7, real
touch events) on a page holding a text field, an
input[type=range], a<button>and adiv role="slider" tabindex="0", with the field focused first each time:input[type=range], tappedinput[type=range], draggeddiv role="slider" tabindex="0"<button>So the caret stays in the field, the on-screen keyboard stays up, and the browser holds the
caret in view against every re-render the slider causes. Safari on iOS withholds the focus
from buttons and tabbable divs as well, and Dawid works on both platforms — which is why the
issue scopes the fix past the two sliders it was reported on.
#153, corrected — the index still
said the easing shipped and that the owner has a sixth parameter. It came out again hours
later in #177, and #175 closed unmerged.
SPEC A13 was updated then; the index was not, so it has been claiming a function the product
does not have. It now says what stands (the coast), what came out (the eased travel and the
Motion switch), and that a work still carrying the switch in its JSON reads as one without
it.
Test plan
pnpm check— green, run after the entries were writtentasks/plan.mdis prettier-clean, verified against a copy normalised to LF (theworking tree on Windows carries CRLF, which prettier flags on the untouched file from
maintoo)origin/main(65a4492), so the R360 motion that eases: a ring click that speeds up and slows down, a drag that coasts, the owner's switch #153 correction sits on the revert itself🤖 Generated with Claude Code