Task index after #66 — and the flaky test that turned main red - #174
Merged
Conversation
…#173) #66 landed with #170: the logo above the auth cards, the place a phone could not add, and both lists put in order by hand. Two things it produced rather than closed: - #173, Dawid's own words on seeing it work — the order is right, the movement is not, and for now it stays. - #172, from the security review — the pool waits for ever and no statement is ever cut off, which is every route rather than that one. And #113 is raised, with the reason written down: a preview running the pull request's image against dev's database means any pull request carrying a migration looks broken on its own preview, exactly when the preview exists to be looked at. Twice now. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`main` went red on the test I wrote, not on the product: `works-order` compared the list of names with a plain expect straight after a key press. That is a snapshot, not a retrying assertion, so it asked the page what it looked like before React had finished putting it there — green on a quiet machine, red on CI. Both specs use `toHaveText` now, which waits. Second one in the same test, and this one my own doing: the order is sent once the moving stops (300 ms), so the reload that follows the second arrow press was racing the request and would have cancelled it in flight. It is waited for, like the first. Nothing in the product changed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Devski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things: the index, and the fix for the test that turned
mainred.The red main
e2e-fullfailed onmainright after #170 merged, on my own test, not on the product — and withe2e-fullred,deploy-devwas skipped, so dev is still serving the pre-#170 image.works-order.spec.tscompared the list of names with a plainexpect(await …).toEqual(…)straight after a key press. That is a snapshot, not a retrying assertion: it asks the page what it looks like before React has finished putting it there. Green on a quiet machine, red on CI. Both reorder specs usetoHaveTextnow, which waits.Nothing in
src/changed.The index
🤖 Generated with Claude Code