Conversation
|
|
|
@Gulin7 Nice work, thanks. Did all the unit tests pass? |
|
@Gulin7 I suggest you run the following chatGPT prompt over this PR and consider updating documentation appropriately. Also, @rofr are you happy not using semver for this project? Perhaps consider marking the existing method as obsolete and create a new method "GetRecordsAsync", and don't add it to the interface, add it to a new interface that derives from the old, so that the new release will be 100% backward compatible? This code also needs new tests for the new API method. Alan |
Fix: #111
Description: