Add remote venv import downloads#64
Open
Adam Driscoll (adamdriscoll) wants to merge 6 commits into
Open
Conversation
Support importing virtual environment archives from HTTP URLs and attaching a bearer token from one-shot environment handoff values. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Adam Driscoll (adamdriscoll)
July 23, 2026 20:38
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds authenticated remote archive support to virtual-environment imports.
Changes:
- Downloads HTTP(S) archives into temporary storage before import.
- Supports one-shot bearer tokens via file or environment variable.
- Documents remote imports and credential handoff.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
crates/multi-pwsh/src/main.rs |
Implements remote downloads, bearer authentication, cleanup, and tests. |
docs/host-and-venv.md |
Documents URL imports and token variables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Require HTTPS before sending venv bearer tokens, configure finite remote archive download timeouts, and add local HTTP server coverage for remote venv imports and HTTP failures. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Adam Driscoll (adamdriscoll)
requested a review
from Marc-André Moreau (mamoreau-devolutions)
July 23, 2026 20:53
Remove token-file handoff support for remote venv imports and keep the direct process environment token flow with cleanup after read. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Drop app-token environment handling for remote venv imports and rely on one-time credentials included in the provided URL query string. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Store ETag metadata for remote venv archive URLs, revalidate with If-None-Match, and reuse the cached archive when the server returns 304 Not Modified. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Adam Driscoll (adamdriscoll)
July 23, 2026 23:53
View session
Store remote venv cache metadata by URL digest, redact query-string credentials from import output, serialize metadata updates with a lock and atomic write, and avoid retry delays for permanent 4xx responses. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote virtual environment archives need to be importable by child
multi-pwshprocesses. This adds URL support tomulti-pwsh venv import, with any one-time credentials supplied as part of the provided URL.Summary
multi-pwsh venv import <name> <archive.zip|url>to downloadhttp://orhttps://zip archives before importing.ETag, keyed by URL digest and ETag, under the existing cache root without persisting raw credential-bearing URLs.If-None-Matchand reuses the cached archive when the server returns304 Not Modified.Validation
cargo test -p multi-pwsh remote_venv -- --nocapturepassed.cargo fmt --all --checkpassed.git diff --checkpassed.cargo clippy --workspace --all-targetspassed with existing warnings in unrelated code.