detect Cask updates parsed with "!=" operator#5157
Merged
Gabriel Dufresne (GabrielDuf) merged 2 commits intoJul 20, 2026
Conversation
Copilot started reviewing on behalf of
Gabriel Dufresne (GabrielDuf)
July 20, 2026 18:38
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Homebrew Cask update detection while preserving Formula support.
Changes:
- Parses both
<and!=update operators. - Extracts parsing into a testable internal method.
- Adds regression coverage and fixtures.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
UniGetUI.PackageEngine.Tests.csproj |
References the Homebrew manager. |
HomebrewManagerTests.cs |
Tests Formula and Cask updates. |
Fixtures/Homebrew/outdated-verbose.txt |
Provides representative output. |
InternalsVisibleTo.cs |
Exposes internals to tests. |
Homebrew.cs |
Supports Cask update syntax and refactors parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Jul 20, 2026
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling and testing of Homebrew package updates, specifically ensuring that both Formula and Cask updates are detected correctly. The main changes include updating the outdated package parsing logic to support multiple comparison operators, refactoring the parser for testability, and adding regression tests to prevent similar issues in the future.
Homebrew update detection improvements:
Homebrew.csto accept both<(Formula) and!=(Cask) operators, ensuring that updates for both types are detected and processed. Previously, only<was accepted, causing Cask updates to be silently dropped.ParseAvailableUpdates, making it easier to unit test and maintain.Testing and test infrastructure:
HomebrewManagerTests.csto verify that both Formula and Cask updates are detected, preventing future regressions.outdated-verbose.txtcontaining sample output for both Formula and Cask updates.InternalsVisibleTofor test access to internal members.