Complete pixel format support for bitmap updates#1134
Open
Greg Lamberson (glamberson) wants to merge 1 commit intoDevolutions:masterfrom
Open
Complete pixel format support for bitmap updates#1134Greg Lamberson (glamberson) wants to merge 1 commit intoDevolutions:masterfrom
Greg Lamberson (glamberson) wants to merge 1 commit intoDevolutions:masterfrom
Conversation
Wire 8/15/24/32bpp bitmap rendering in the session layer. Previously only 16bpp (compressed and uncompressed) and 32bpp RDP6-compressed bitmaps were handled; all other depths were silently dropped. Changes: - Add rdp_15bit_to_rgb (RGB555) conversion in ironrdp-graphics - Add apply_rgb15_bitmap, apply_bgr24_bitmap, apply_rgb8_with_palette in DecodedImage - Wire all pixel formats in fast-path compressed, uncompressed, and surface CODEC_ID_NONE paths - Add FastPathUpdate::Palette variant, parse TS_UPDATE_PALETTE_DATA - Include default Windows system palette (VGA 20-color) for 8bpp sessions that start without an explicit palette update - Add unit tests for 15-bit and 16-bit color conversion Partial fix for Devolutions#314.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires 8/15/24/32bpp bitmap rendering in the session layer. Previously only 16bpp and 32bpp RDP6-compressed bitmaps were rendered; all other depths were silently dropped with warn!(). The RLE decompressor already handles all four formats correctly, the gap was entirely in dispatch and image application.
Partial fix for #314.