fix(server): tile bitmaps that exceed MultifragmentUpdate limit#1133
Merged
Benoît Cortier (CBenoit) merged 1 commit intoDevolutions:masterfrom Mar 1, 2026
Merged
Conversation
Guillaume Gelin (ramnes)
force-pushed
the
ramnes/tile-bitmaps
branch
3 times, most recently
from
131af74 to
e2d3ee7
Compare
The `NoneHandler` sends uncompressed surface commands whose size is proportional to the bitmap area. On large desktops (e.g. 3008x1692 at 32bpp ~ 20 MB), a single surface command easily exceeds the negotiated `MultifragmentUpdate` reassembly buffer (8 MB by default), causing clients to disconnect. The approach here is to split oversized dirty rects into horizontal strips that fit within `max_request_size` before handing them to the bitmap encoder.
Guillaume Gelin (ramnes)
force-pushed
the
ramnes/tile-bitmaps
branch
from
e2d3ee7 to
d78fccf
Compare
Benoît Cortier (CBenoit)
approved these changes
Mar 1, 2026
Member
Benoît Cortier (CBenoit)
left a comment
Benoît Cortier (CBenoit)
left a comment
There was a problem hiding this comment.
LGTM! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
NoneHandlersends uncompressed surface commands whose size is proportional to the bitmap area. On large desktops (e.g. 3008x1692 at 32bpp ~ 20 MB), a single surface command easily exceeds the negotiatedMultifragmentUpdatereassembly buffer (8 MB by default), causing clients to disconnect.The approach here is to split oversized dirty rects into horizontal strips that fit within
max_request_sizebefore handing them to the bitmap encoder.