Conversation
koral--
left a comment
koral--
left a comment
There was a problem hiding this comment.
Your PR does not pass CI build.
Also sign off is missing
| # installs development files for node-gyp so that npm install won't have to | ||
| # wait for them on the first native module installation. | ||
| RUN export DEBIAN_FRONTEND=noninteractive && \ | ||
| useradd --system \ |
There was a problem hiding this comment.
Your PR does not pass CI build.
Can you provide more information, or main error it's missing signing?
also sign off is missing
Okay, 5 mins
| rethinkdb: | ||
| container_name: rethinkdb | ||
| image: rethinkdb:2.3 | ||
| image: rethinkdb:latest |
There was a problem hiding this comment.
We should use fixed version.
It is ok to update to 2.4.1 but not to latest.
|
@koral-- can you reply, why in docker file you don't use nvm and latest nodejs version? |
|
STF won't build with latest node version. |
okay, I will try to fix it |
Updated to latest version of RDB. With old version project is not started Removed yarn.lock Version dump Version dump
This reverts commit e17007f.
This reverts commit e17007f.
# Conflicts: # package.json
|
@koral, can you describe the actual codebase status? I would suggest separate frontend from backend and rewrite it to nestsjs and modern angular |
|
I'm not a JS expert but will try to answer.
Correct.
Which method?
LGTM at a glance. Upgrading Angular is perfectly reasonable. |
I don't know how to change authentication method, but I always get auth_mock in URL
NestJS has express/fastify framework in the core, it's just a wrapper that will provide typization. And this framework has is angular-like code style. And I saw repos stf_ios_support and stf-ios-provider, can you describe what is it? I don't fully understand the structure of the project |
|
Regarding auth there are a few methods available: look at https://github.com/DeviceFarmer/stf/blob/master/doc/DEPLOYMENT.md#stf-authservice Regarding NestJS fine for me, if you will be able to rewrite using it, PRs are welcome. Regarding iOS-related repos this is an unfinished @nanoscopic's work about iOS support. |
2 participants
Updated versions of database to latest. And Ubuntu from 16 to 21