fix: serialize Windows frontend dependency setup - #1218
Merged
marcomarcogd merged 1 commit intoSep 21, 2026
Merged
marcomarcogd merged 1 commit into
marcomarcogd merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows builds can run
npm ciwhile Wails scans Go packages to generate bindings. On Windows this intermittently locks or removes files underfrontend/node_modules, causingEBUSYor invalid Go import-path failures.This change makes frontend dependency installation a single ordered prerequisite of binding generation. Frontend compilation then depends on the completed bindings, so Wails never scans a mutating
node_modulestree.Validation:
npm cifailed withEBUSYwhile bindings ran concurrently)task buildgit diff --check