feat(install): show hidden files in macOS Finder - #869
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughA macOS setup script enables Finder’s ChangesFinder hidden-file configuration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The change enables hidden-file visibility in Finder after the user relaunches Finder or signs out and back in. No material merge-readiness risk is established. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change is limited to a macOS Finder display preference and does not show an access-control change. The preference persists until changed again, and its effect in Finder requires a relaunch or sign-out. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Why
Hidden dotfiles should be visible in Finder by default on macOS devices managed by these dotfiles.
Approach
Add a native macOS-only Chezmoi
run_onchangescript that sets the current user'scom.apple.finder AppleShowAllFilespreference totrue. It applies in both light and full installations, reports write failures, and leaves Linux and Windows unchanged.Finder is deliberately not restarted automatically to avoid interrupting file operations. The setup output and installation documentation explain that users should relaunch Finder or sign out and back in. The preference is configured on the first apply and whenever the script changes.
Validation
chezmoi apply --dry-run --verbosepreviews include the preference.Summary by CodeRabbit