Skip to content

Revert: #33618 Grid Demos csp fix — to verify visual tests regression source#33676

Closed
aleksei-semikozov wants to merge 1 commit into
DevExpress:26_1from
aleksei-semikozov:revert-33618-26_1
Closed

Revert: #33618 Grid Demos csp fix — to verify visual tests regression source#33676
aleksei-semikozov wants to merge 1 commit into
DevExpress:26_1from
aleksei-semikozov:revert-33618-26_1

Conversation

@aleksei-semikozov
Copy link
Copy Markdown
Contributor

Diagnostic revert of #33618 (Grid Demos: fix csp in treelist-overview and grid-rowselection).

Purpose: confirm that #33618 (merged 2026-05-19 12:51 as commit 685ce5f5) is the root cause of jquery screenshot test regression on 26_1.

Evidence pointing at #33618:

Bisection summary (visual-tests-demos.yml on 26_1):

Date Commit Title jquery fails
5-18 ... up to 36c73f41 various all green
5-19 10:17 312163ac CI publish tag all green
5-19 12:51 685ce5f5 #33618 Grid Demos csp first ❌ (2/3-material)
5-19 13:56 74714d8e #33622 AI utils +1 fail
... ... ... escalating
5-21 21:11 d9629585 #33628 webpack stable 4/6 fail

Diagnostic PRs already done:

Expected outcome: if jquery tests pass on this revert PR, #33618 is the root cause and team needs to:

@aleksei-semikozov
Copy link
Copy Markdown
Contributor Author

Diagnostic complete. Reverting #33618 does NOT fix the regression — same 4 jquery tests still fail.

Root cause identified separately: timing issue with remote-data demos (DataGrid/AIColumns hitting OpenAI proxy, DataGrid/RemoteVirtualScrolling + RemoteGrouping + PivotGrid/WebAPIService hitting js.devexpress.com Sales API). Screenshot capture happens before async data finishes loading.

See diff artifacts: 'Loading...' text visible in actual screenshots; affected demos all fetch from external sources.

Likely catalyst: #33639 (Demos: DataGrid/TreeList aicolumn — handle inline module) which changed JS loading timing for AI demos. Real fix needed: increase screenshot wait timeouts, mock external data in CI, or skip AI/Remote demos in visual tests.

@aleksei-semikozov aleksei-semikozov deleted the revert-33618-26_1 branch May 22, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant