Repository navigation
docs(readme): the demo plays in place, YouTube kept for full HD - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The README showed a YouTube thumbnail: a click away from the page, and away from GitHub. GitHub plays a video inline only when it is a GitHub upload, so the demo now is one.
What changed
README.md: the YouTube thumbnail is replaced by a GitHub-hosted copy of the demo (user-attachments/assets/881eebc2…), which GitHub renders as an inline player. The caption keeps the YouTube link for the full-HD version.promo-share.mp4(two-pass H.264 at 380 kb/s, AAC 64 kb/s, 9.0 MB), to fit GitHub's 10 MB attachment limit; same 2:44 length.Verification
<video controls>element, and its signed source returns200 video/mp4, 9,026,422 bytes.