fix(examples): crop the engine banner tight to its content#208
Merged
Conversation
The standalone engine-banner page used full A4-landscape on a 16pt margin and a 30pt panel pad, so the top-anchored logo→chips stack sat inside a thick dead dark border (and a slack band below the capability chips). Size the page to the content instead — 801x525 with an 8pt margin and an 18pt panel pad — so the width hugs the 749pt rules, the height wraps the stack in one page, and the rasterised hero is all signal with only a thin frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
EngineDeckExample.generateBanner()rendered the standalone engine-banner on a full A4-landscape page (842×595) with a 16pt margin and a 30pt panel pad. The banner content is a top-anchored stack, so it sat inside a thick dead dark border with extra slack below the capability chips — the rasterised hero wasted space and read small.What changed
801×525(wasDocumentPageSize.A4.landscape()).16 → 8, banner panel pad30 → 18.Only
generateBanner()and the banner panel are touched — the four-page deck (generate(), snapshot-locked byEngineDeckLayoutSnapshotTest) is unchanged.Verification
801×525, nothing clipped or paginated (512pt paginated — 525 is the safe single-page minimum)../mvnw -f examples/pom.xml compile→ exit 0.Committed previews are untouched — the release
cutre-renders the banner card, keeping it consistent.