feat(examples): render the README hero from the EngineDeck banner#199
Merged
Conversation
The repository README hero was a portrait CV promo. Replace it with the EngineDeck page-1 banner — the engine's own brand panel — rendered full-bleed: a new EngineDeckExample.generateBanner() paints the dark violet field as the canonical page background, so it fills the whole landscape page (margins and corners included) and the rasterised PNG carries no white frame, only the banner. Bumping the shown version is now one rebuild — the banner reads VERSION / CODENAME. Overwrites assets/readme/repository_showcase_render.png in place (the README reference is unchanged); EngineShowcase's Javadoc now points at the new hero source.
DemchaAV
changed the base branch from
feature/flagship-showcase-document
to
develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The repository README hero was a portrait CV promo. The EngineDeck page-1 banner — the engine's own brand panel carrying the current version — is a better fit, and it lets the hero stay current with one rebuild instead of a hand-edited image.
What
EngineDeckExample.generateBanner()renders the page-1 banner standalone on a single landscape page, painting the dark violet field as the canonicalpageBackgroundso it fills the page edge to edge — no white frame, only the banner.assets/readme/repository_showcase_render.pngwith the rasterised banner (the README reference is unchanged). Bumping the shown version is now one rebuild — the banner readsVERSION/CODENAME.EngineShowcase's Javadoc now points at the new hero source.Tests
EngineDeckLayoutSnapshotTestgreen — the banner layout is unchanged (the deck and the hero sharebanner()).PdfPageRasterizer; the PNG is full-bleed dark with the full banner and no white frame.Stacked on #197 (reuses its EngineDeck banner code); base retargets to
developafter #197 merges.