Skip to content

fix(benchmarks): widen the comparative label column so long Jasper rows align #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DemchaAV merged 2 commits into from
Jun 16, 2026
Merged

fix(benchmarks): widen the comparative label column so long Jasper rows align #198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8985e9d
fix(benchmarks): widen the comparative label column so long Jasper ro…
DemchaAV Jun 15, 2026
cc55eec
refactor(benchmarks): derive comparative table widths from the longes…
DemchaAV Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 38 additions & 7 deletions benchmarks/src/main/java/com/demcha/compose/ComparativeBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,19 @@ public class ComparativeBenchmark {
private static final int SWEEP_WARMUP_ITERATIONS = 20;
private static final int SWEEP_MEASUREMENT_ITERATIONS = 30;

// Per-library table layout, derived from the widest label any row can print so a
// longer label (e.g. a bigger sweep size) can never overflow the column and break
// the alignment again — a fixed column width is the failure mode this once had.
private static final int LABEL_WIDTH = widestLabelWidth();
private static final String TABLE_HEADER_FORMAT = "%-" + LABEL_WIDTH + "s | %14s | %14s%n";
private static final String TABLE_ROW_FORMAT = "%-" + LABEL_WIDTH + "s | %14.2f | %14.2f%n";
private static final int TABLE_RULE_WIDTH = LABEL_WIDTH + 3 + 14 + 3 + 14;

// Scaling-summary table: an 8-wide row-count column plus four 16-wide ratio columns.
private static final String SUMMARY_HEADER_FORMAT = "%-8s | %16s | %16s | %16s | %16s%n";
private static final String SUMMARY_ROW_FORMAT = "%-8d | %16s | %16s | %16s | %16s%n";
private static final int SUMMARY_RULE_WIDTH = 8 + 4 * (3 + 16);

private static final String REPORT_PROSE =
("GraphCompose lays out structured business documents across many pages "
+ "while keeping header and footer placement stable. ").repeat(6);
Expand Down Expand Up @@ -147,7 +160,7 @@ public static void main(String[] args) throws Exception {
"%.2f".formatted(row.avgTimeMs()),
"%.2f".formatted(row.avgHeapMb())))
.toList());
System.out.println("-".repeat(60));
System.out.println("-".repeat(TABLE_RULE_WIDTH));
System.out.println("Saved JSON benchmark report to " + jsonPath);
System.out.println("Saved CSV benchmark report to " + csvPath);

Expand Down Expand Up @@ -178,8 +191,8 @@ private static Path writeSampleRenders(Path directory) throws Exception {
}

private static void printTableHeader() {
System.out.printf("%-24s | %14s | %14s%n", "Library", "Avg Time (ms)", "Avg Heap (MB)");
System.out.println("-".repeat(60));
System.out.printf(TABLE_HEADER_FORMAT, "Library", "Avg Time (ms)", "Avg Heap (MB)");
System.out.println("-".repeat(TABLE_RULE_WIDTH));
}

private static Measured runBenchmark(String name, int iterations, BenchmarkTask task) throws Exception {
Expand Down Expand Up @@ -209,7 +222,7 @@ private static Measured runBenchmark(String name, int iterations, BenchmarkTask
double avgTimeMs = (totalTimeNs / (double) iterations) / 1_000_000.0;
double avgMemMb = (totalAllocatedBytes / (double) iterations) / (1024.0 * 1024.0);

System.out.printf("%-24s | %14.2f | %14.2f%n", name, avgTimeMs, avgMemMb);
System.out.printf(TABLE_ROW_FORMAT, name, avgTimeMs, avgMemMb);

// Печатаем dummy-переменную, чтобы JIT не вырезал код генерации
if (dummyAccumulator == 0) System.out.println("Error: No bytes generated");
Expand Down Expand Up @@ -473,6 +486,24 @@ private static double round(double value) {
return Math.round(value * 100.0) / 100.0;
}

/**
* The widest label printed in the per-library tables, plus one space of padding.
* "JasperReports" is the longest library name, so its largest-sweep row is the
* widest generated label; the fixed small-invoice labels are checked too in case
* the sweep sizes are ever made tiny.
*/
private static int widestLabelWidth() {
int maxSize = 0;
for (int size : SWEEP_SIZES) {
maxSize = Math.max(maxSize, size);
}
int widest = ("JasperReports (" + maxSize + " rows)").length();
for (String fixed : new String[]{"Library", "GraphCompose Canonical"}) {
widest = Math.max(widest, fixed.length());
}
return widest + 1;
}

/**
* Prints how GraphCompose's time/memory advantage over iText and Jasper changes
* as the row count grows, so the "does the lead widen with document size?"
Expand All @@ -482,11 +513,11 @@ private static double round(double value) {
private static void printScalingSummary(List<ScalingPoint> scaling) {
System.out.println();
System.out.println("Scaling summary (GraphCompose advantage; >1.0 = GraphCompose faster / lighter)");
System.out.printf("%-8s | %16s | %16s | %16s | %16s%n",
System.out.printf(SUMMARY_HEADER_FORMAT,
"Rows", "Time vs iText", "Time vs Jasper", "Heap vs iText", "Heap vs Jasper");
System.out.println("-".repeat(86));
System.out.println("-".repeat(SUMMARY_RULE_WIDTH));
for (ScalingPoint p : scaling) {
System.out.printf("%-8d | %16s | %16s | %16s | %16s%n",
System.out.printf(SUMMARY_ROW_FORMAT,
p.rows(),
ratio(p.iText().timeMs(), p.graphCompose().timeMs()),
ratio(p.jasper().timeMs(), p.graphCompose().timeMs()),
Expand Down