chore(benchmarks): remove three redundant benchmark mains#194
Closed
DemchaAV wants to merge 1 commit into
Closed
Conversation
FullCvBenchmark duplicated the JMH TemplateCvJmhBenchmark (CV through ModernProfessional) with a hand-rolled, JIT-noisier loop and no report. GraphComposeBenchmark was an early-engine relic measuring the same title+body+divider doc as CurrentSpeedBenchmark's engine-simple scenario. ScalabilityBenchmark's thread-scaling sweep is folded into CurrentSpeedBenchmark's full-profile throughput run (thread counts now 1,2,4,8,16). Drop the matching run-benchmarks.ps1 steps and the benchmarks.md / benchmarks/README.md entries. ComparativeBenchmark, the JMH benches, the deterministic probes, and the soak/stress runners stay. Benchmark module compiles; its 28 tests pass.
6fdff09 to
917f3ce
Compare
Owner
Author
|
Не вливаем в develop по-шагово. B1 свёрнут в интеграционную ветку chore/benchmark-modernization — вся модернизация бенчмарков уйдёт в develop одним PR в конце. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of the benchmark-suite modernization (cleanup before adding v1.8 feature-object benches). Benchmark module only — not shipped.
What
Removed three redundant benchmark mains:
FullCvBenchmark— duplicated the JMHTemplateCvJmhBenchmark(CV throughModernProfessional) with a hand-rolled, JIT-noisier loop and no JSON/CSV report.GraphComposeBenchmark— early-engine relic measuring the same title+body+divider doc asCurrentSpeedBenchmark'sengine-simplescenario.ScalabilityBenchmark— its thread-scaling throughput sweep is folded intoCurrentSpeedBenchmark's full-profile run (DEFAULT_FULL_THREAD_COUNTSnow1,2,4,8,16, smoke unchanged — no throughput).Dropped the matching
run-benchmarks.ps1steps (04-core-engine/05-full-cv/06-scalability) and thedocs/operations/benchmarks.md+benchmarks/README.mdentries.Kept (deliberately)
ComparativeBenchmark(cross-library vs iText5/JasperReports — wanted for tracking standing vs other libs), the three JMH benches, the deterministic probes (MeasurementCount,RenderOperator,TablePaginationAlloc,AutoSizeMeasure,FontEmbed), and the soak/stress runners (EnduranceTest,GraphComposeStressTest).Verification
./mvnw -f benchmarks/pom.xml clean compile→ BUILD SUCCESS (19 files, was 22);./mvnw -f benchmarks/pom.xml test→ 28 tests, 0 failures (incl.CurrentSpeedBenchmarkPerfGateTest— smoke gate unaffected). No remaining Java/pom references to the removed classes.Lane: benchmark tooling (perf).